MopaBootstrapBundle icon indicating copy to clipboard operation
MopaBootstrapBundle copied to clipboard

Revert "Delete spinning file" because this file is still referenced

Open bluntelk opened this issue 9 years ago • 6 comments

and required

This reverts commit 7a3b15c3b6b08b01b9075b0cefbfb018eca9f682.

bluntelk avatar Dec 21 '15 03:12 bluntelk

This is a simple commit to revert a change that is causing grief for users using Font Awesome LESS files

bluntelk avatar Dec 21 '15 04:12 bluntelk

no sure what this is for ;-) could you explain the use case a bit ? thanks for this contribution

phiamo avatar Jan 04 '16 14:01 phiamo

Hi @phiamo

Sure. This commit is simply reverting a deleted file (spinning.css).

This file is still referenced by https://github.com/phiamo/MopaBootstrapBundle/blob/master/Resources/public/less/font-awesome4/font-awesome.less

For LESS users, this is causing the assets to fail when dumping. We then get broken CSS and no styling.

bluntelk avatar Jan 04 '16 15:01 bluntelk

Hi @phiamo

Any chance of having this PR merged?

bluntelk avatar Jan 07 '16 02:01 bluntelk

@isometriks do you see chances this could break anything ?

phiamo avatar Feb 03 '17 18:02 phiamo

Nope, should be fine. Although I plan on removing any embedded libraries in this repo, so I would suggest against anybody using it this way anyway.

isometriks avatar Feb 03 '17 19:02 isometriks