Add proprietary goodix blobs for Xiaomi Mi A2 / 6X

[tytydraco]

Xiaomi's Mi A2 and Mi 6X stock vendor requires goodix fingerprint sensore blobs to be located under /system/etc/firmware/ in order to be loaded correctly. Testing this with a Magisk module yields expected results:

• Fingerprint sensor is recognized in settings
• Fingerprint sensor functions correctly upon identification

Signed-off-by: Tyler Nijmeh [email protected]

[tytydraco]

@penn5 Take a look now; I force-pushed. Let me know if I did it right, as I don't have a machine currently prepared to test my own changes.

Thanks in advance :)

[phhusson]

Not a bad first try.

1. By default, /system/etc/firmware doesn't exist, so you can't copy it, or mount it. My recommendation is that you create it by simply putting an empty file there
2. Please have the file names in device/phh/treble and system/phh more explicit to mention the name of your platform
3. Please don't put that code in keylayout, but add a new section at the end of the file in a <IF your platform>

[penn5]

^

[phhusson]

Is there a property to check if it's longcheer?

Le sam. 22 juin 2019 à 03:45, suwakowww [email protected] a écrit :

@suwakowww commented on this pull request.

In rw-system.sh https://github.com/phhusson/device_phh_treble/pull/110#discussion_r296429960 :

@@ -309,6 +335,15 @@ if getprop ro.vendor.build.fingerprint | grep -qE '^xiaomi/(daisy|wayne)/(daisy| setprop audio.camerasound.force true fi

+if getprop ro.vendor.build.fingerprint | grep -iq \

•    -e xiaomi/polaris -e xiaomi/sirius -e xiaomi/dipper \
  

•    -e xiaomi/wayne -e xiaomi/jasmine -e xiaomi/jasmine_sprout \
  

•    -e xiaomi/platina -e iaomi/perseus -e xiaomi/ysl \
  

•    -e xiaomi/nitrogen -e xiaomi/daisy -e xiaomi/sakura \
  

Seems not all devices need this. Goodix fingerprint working well on dipper without this fix. But wayne/jasmine/whyred/tulip should need this, maybe lavender/violet need this, too. Because they all made by longcheertel.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/phhusson/device_phh_treble/pull/110?email_source=notifications&email_token=AAAA4OTSSZ6J46D3BRTJTYLP3V74FA5CNFSM4HPVXO32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4K2NLY#discussion_r296429960, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAA4OROM6SH2WCSXL7NNQTP3V74FANCNFSM4HPVXO3Q .

[suwakowww]

Seems there's no way to check on any custom ROMs. When on stock ROM, just dial *#*#6484#*#*, it will open "cit" tool, then take a screenshot on this tool, it will show the package name. If this device made by Xiaomi, it will be com.miui.cit, or if this device made by longcheer, it will be com.longcheertel.cit.