device_phh_treble icon indicating copy to clipboard operation
device_phh_treble copied to clipboard

Published 20 hours ago • verified publisher icon phhusson

Enable the approval of incoming call for MTK Radio v2

Open bevis-tseng opened this issue 5 years ago • 13 comments

EAIC=3 is not workable on some MTK devices such as Nokia 1. A more comprehensive approach is to approve the incoming call from Telephony F/W to prevent changing anything in vendor partition.

This patch is a legacy to reverse the change in mtk-ril.so files of disabling the approval of incoming call: s/AT+EAIC=2/AT+EAIC=3/g on the devices flashed with Phh-Treble GSI. This EAIC modification is expected to be removed eventually once no more mtk-ril.so has to be reversed.

bevis-tseng avatar Apr 19 '19 05:04 bevis-tseng

@phhusson add all his pulls plz, it s works

Skyrimus avatar May 07 '19 23:05 Skyrimus

it's merged in https://github.com/phhusson/platform_frameworks_opt_telephony/commit/b5b08cef78a344d673f8546feb9e1a132e2312b8

I don't believe doing this change in device_phh_treble is needed to have that fix working; but applying this change would break incoming calls on pie vendors and older oreo vendors

phhusson avatar May 08 '19 15:05 phhusson

@phhusson it need some tests on some devices

Skyrimus avatar May 09 '19 22:05 Skyrimus

Maybe nothing will be break

Skyrimus avatar May 09 '19 22:05 Skyrimus

This patch is to skip the s/AT+EAIC=2/AT+EAIC=3/g change that have been done by @phhusson for devices with MTK radio v2. This is required for some device like Nokia 1 to make the patch in https://github.com/phhusson/platform_frameworks_opt_telephony/commit/04a9d8b4582f52b0371fa5c8e863c32b19b97b2b works effectively after testing.

bevis-tseng avatar May 13 '19 05:05 bevis-tseng

@bevis-tseng can you give me *.img for test? Like arm image

Skyrimus avatar May 13 '19 09:05 Skyrimus

@Skyrimus v113 already has that fix.

phhusson avatar May 13 '19 09:05 phhusson

@bevis-tseng maybe can add full support for mtk ril? I can give you some source for HALs

Skyrimus avatar May 13 '19 10:05 Skyrimus

What does "full support" mean?

Le lun. 13 mai 2019 à 12:13, Skyrimus [email protected] a écrit :

@bevis-tseng https://github.com/bevis-tseng maybe can add full support for mtk ril? I can give you some source for HALs

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/phhusson/device_phh_treble/pull/102#issuecomment-491762673, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAA4ORKYRHFVVH3NTQIH3DPVE5NVANCNFSM4HHCA4VQ .

phhusson avatar May 13 '19 10:05 phhusson

@phhusson support for all mtk ril features by native, i have hals and other mtk source 8.1 and 9.0

Skyrimus avatar May 13 '19 10:05 Skyrimus

Because some devices have troubles with sim working, when use sim in second slot - it s give No service and nothing works

Skyrimus avatar May 13 '19 10:05 Skyrimus

Sorry, but that's never going to happen. Some features are specific to one single carrier, some features are, IMO, malwares, some require hardware not available to the public (eMBMS, femtocells, ...), etc.

Le lun. 13 mai 2019 à 12:39, Skyrimus [email protected] a écrit :

@phhusson https://github.com/phhusson support for all mtk ril features by native, i have hals and other mtk source 8.1

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/phhusson/device_phh_treble/pull/102#issuecomment-491770844, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAA4OQPXTX4Z26JGUFTWGTPVFAP5ANCNFSM4HHCA4VQ .

phhusson avatar May 13 '19 10:05 phhusson

Ok, i will test it on mt6735, i think it will work, because on Nokia 1 soc mt6737

Skyrimus avatar May 13 '19 17:05 Skyrimus