Always enable the approval of incoming call.

[bevis-tseng]

EAIC=3 is not workable on some MTK devices such as Nokia 1. A more comprehensive approach is to approve the incoming call from Telephony F/W to prevent changing anything in vendor partition.

This patch is a legacy to reverse the change in mtk-ril.so files of disabling the approval of incoming call: 's/AT+EAIC=2/AT+EAIC=3/g' on the devices flashed with Phh-Treble GSI. This EAIC modification is expected to be removed eventually once no more mtk-ril.so has to be reversed.

[phhusson]

Thing is, this sed works for vendor radio HAL 1.0 and 3.0, that your PR doesn't support (yet). I don't mind merging frameworks/opt/telephony patch, but this one, I mind a bit more. Perhaps I can just leave a if vendor radio hal != 2.0, do the sed (There is no need to do 3 => 2, since the change is temporary, in RAM, it never hits actual storage)

[bevis-tseng]

Perhaps I can just leave a if vendor radio hal != 2.0, do the sed.

Sounds better than my approach!

(There is no need to do 3 => 2, since the change is temporary, in RAM, it never hits actual storage)

Thanks for pointing out this.

[bevis-tseng]

@phhusson, I've updated the patches of pie/oreo to skip the sed change if hal != 2.0. I don't have MTK devices in with HAL 1 or HAL 3 in my hand. The assumption of this change is that the /vendor/lib/[email protected]_vendor.so is only available for hal 2.0 devices. Please correct me if there is better way to identify the HAL version.

BTW, do you know which device includes vendor Radio HAL 3.0? I could try to find one to double check if it's the correct approach to identify the HAL version via these .so file names.

[phhusson]

Radio HAL 3.0 will be devices running natively Android Pie. I think that vendor radio HAL 1.x is for early Oreo-MR0 devices? Most of them have radio HAL 2.x though

I usually rather grep for the HAL in /vendor/etc/vintf/manifest.xml // /vendor/manifest.xml, but I guess your way works too (perhaps not on O-MR0 where libs won't have _vendor suffix)