tuner.coffee icon indicating copy to clipboard operation
tuner.coffee copied to clipboard

Tuner doesn't seem to calculate note properly

Open kusog opened this issue 10 years ago • 4 comments

In my initial test, it seems to show the wrong note. I am running a trusted tuner and using a simple recorder and see that this tuner is not showing the proper note. Have you tested this actually works properly, not just runs and appears to work?

kusog avatar Nov 13 '14 02:11 kusog

Yes, I've used it for almost 2 years now. It's not perfect, and there's definitely room for improvement, particularly in some of the heuristics it uses for removing potential harmonics. If you could give some more details, I could have a look.

phenomnomnominal avatar Nov 13 '14 03:11 phenomnomnominal

It appears to work if I put the recorder right near mic. Is there a sensitivity option?

From: Craig Spence [mailto:[email protected]] Sent: Wednesday, November 12, 2014 10:09 PM To: phenomnomnominal/tuner.coffee Cc: kusog Subject: Re: [tuner.coffee] Tuner doesn't seem to calculate note properly (#2)

Yes, I've used it for almost 2 years now. It's not perfect, and there's definitely room for improvement, particularly in some of the heuristics it uses for removing potential harmonics. If you could give some more details, I could have a look.

— Reply to this email directly or view it on GitHub https://github.com/phenomnomnominal/tuner.coffee/issues/2#issuecomment-62834479 . https://github.com/notifications/beacon/ABCRorAc8AlSx6WHoFs-44Bdzuihtvwhks5nNBg6gaJpZM4C6dBV.gif

kusog avatar Nov 13 '14 03:11 kusog

I want to integrate it into my code http://kusogmusic.com/compact

From: Craig Spence [mailto:[email protected]] Sent: Wednesday, November 12, 2014 10:09 PM To: phenomnomnominal/tuner.coffee Cc: kusog Subject: Re: [tuner.coffee] Tuner doesn't seem to calculate note properly (#2)

Yes, I've used it for almost 2 years now. It's not perfect, and there's definitely room for improvement, particularly in some of the heuristics it uses for removing potential harmonics. If you could give some more details, I could have a look.

— Reply to this email directly or view it on GitHub https://github.com/phenomnomnominal/tuner.coffee/issues/2#issuecomment-62834479 . https://github.com/notifications/beacon/ABCRorAc8AlSx6WHoFs-44Bdzuihtvwhks5nNBg6gaJpZM4C6dBV.gif

kusog avatar Nov 13 '14 03:11 kusog

There's possibly something that can be done with the noise removal stuff. Have a look at the docs. I'll have a fiddle later on, but it's a pretty hard one to get working, since stock computer microphones are mostly shit.

phenomnomnominal avatar Nov 13 '14 03:11 phenomnomnominal