Craig Spence

I had a go at adding unit tests to the PR in ESQuery, but other tests were failing and I don't have time to dig into them right now 😕...

Thank you so much for your work on this! I'm not really sure how the PR should work, you could just do it against esquery and see what happens? Might...

Just updating the version and then publishing it 😊

Ah yep, too right. Once their PR gets merged and released I can port over the matcher and the tests too.

TSQuery’s matcher implementation is almost identical to ESQuery, I’ve just split it up a bit more and renamed stuff. If you’d like to make a PR of where you’ve got...

Do we know that they don’t? Let’s give them a little nudge first, and see what needs to happen for it to be merged.

I'd be keen for an official implementation of this too. I guess for now you could just make the name of the inputs the array index, and then use `Array.from`,...

I mean it’s kind of finished? What needs updating?

Thanks for this, I'll check it out this weekend properly when I get a sec. My first thoughts are to dig into the "side-band to the AST" thing - is...

Yeah I've done a bit of thinking about this too, and I *think* I agree with you. I'd be happy to make the breaking change if it makes this whole...