betterer icon indicating copy to clipboard operation
betterer copied to clipboard

VS Code Results not showing, specific file

Open abrenneke opened this issue 4 years ago • 5 comments
trafficstars

Dang, still got into a situation where results aren't showing.

The logs look okay though:

[Info  - 2:49:28 PM] Validator: Got issues from Betterer for "eslint comments"
[Info  - 2:49:28 PM] Validator: eslint comments got "3" existing issues for "/Users/andy.brenneke/code/work/ironclad/harbor/packages/harbor-meta/src/betterer.ts"
[Info  - 2:49:28 PM] Validator: eslint comments got "0" new issues for "/Users/andy.brenneke/code/work/ironclad/harbor/packages/harbor-meta/src/betterer.ts"
[Info  - 2:49:28 PM] Validator: Got issues from Betterer for "no-extraneous-dependencies"
[Info  - 2:49:28 PM] Validator: no-extraneous-dependencies got "9" existing issues for "/Users/andy.brenneke/code/work/ironclad/harbor/packages/harbor-meta/src/betterer.ts"
[Info  - 2:49:28 PM] Validator: no-extraneous-dependencies got "0" new issues for "/Users/andy.brenneke/code/work/ironclad/harbor/packages/harbor-meta/src/betterer.ts"
[Info  - 2:49:28 PM] Validator: Sending 12 diagnostics to "file:///Users/andy.brenneke/code/work/ironclad/harbor/packages/harbor-meta/src/betterer.ts".
[Info  - 2:49:28 PM] Server: Processing queue at 1623880168644
[Info  - 2:49:28 PM] Server: Queue empty, nothing to do.
[Info  - 2:49:28 PM] Validator: Restoring CWD to "/".

Looks like it sent the diagnostics to VS Code successfully, but I'm not seeing anything in this specific file 🤔

Other files seem to be working fine. Maybe there's just something funky about this eslint-comments rule.

The rule:

'eslint comments': eslint({
    'eslint-comments/disable-enable-pair': 'error',
    'eslint-comments/no-aggregating-enable': 'error',
    'eslint-comments/no-duplicate-disable': 'error',
    'eslint-comments/no-unlimited-disable': 'error',
    'eslint-comments/no-unused-disable': 'error',
    'eslint-comments/no-unused-enable': 'error',
    'eslint-comments/require-description': 'error',
  }).include('./packages/**/src/**/*.*'),

abrenneke avatar Jun 16 '21 21:06 abrenneke

[Info  - 2:49:28 PM] Validator: Sending 12 diagnostics to "file:///Users/andy.brenneke/code/work/ironclad/harbor/packages/harbor-meta/src/betterer.ts".

This should be sending the issues to the file with the issues, so just want to check that you're testing in there?

phenomnomnominal avatar Jun 16 '21 22:06 phenomnomnominal

Yeah harbor-meta/src/betterer.ts was the file I had open in VS Code, I know exactly where the errors should have been appearing

abrenneke avatar Jun 16 '21 22:06 abrenneke

This is a wild guess, but does it work if the file is called something else? Wondering if I do some weird filtering on .betterer.ts somewhere and it's not working right.

phenomnomnominal avatar Jun 17 '21 00:06 phenomnomnominal

Nah still no good :(

[Info  - 8:22:53 PM] Validator: Sending 12 diagnostics to "file:///Users/andy.brenneke/code/work/ironclad/harbor/packages/harbor-meta/src/worser.ts".

abrenneke avatar Jun 17 '21 03:06 abrenneke

This seems specific to eslint-plugin-eslint-comments! I disabled those rules in a file that wasn't working and suddenly problems showed up.

abrenneke avatar Jul 08 '21 01:07 abrenneke