betterer icon indicating copy to clipboard operation
betterer copied to clipboard

feat(stylelint ✨): add support for stylelint 14

Open manbearwiz opened this issue 2 years ago • 3 comments

BREAKING CHANGE: Requires stylelint@^14, config change

Stylelint removed the configOverrides option. The config passed to stylelint now replaces the configuration loaded from .stylelintrc.

See the Stylelint Migration Guide for details.

manbearwiz avatar Nov 07 '22 20:11 manbearwiz

If you would prefer to handle this stylelint breaking change another way, please let me know. Stylelint does expose a resolveConfig function to get the config for a file; however, that would mean calling resolveConfig and lint on each file individually.

manbearwiz avatar Nov 07 '22 20:11 manbearwiz

Thanks for the PR! The resolveConfig option sounds interesting, I guess that makes it more like how ESLint runs, where different files can have wildly different configs. It could line up with ./packages/eslint/src/eslint.ts quite nicely?

phenomnomnominal avatar Nov 08 '22 03:11 phenomnomnominal

Thanks for the PR! The resolveConfig option sounds interesting, I guess that makes it more like how ESLint runs, where different files can have wildly different configs. It could line up with ./packages/eslint/src/eslint.ts quite nicely?

@phenomnomnominal - do you know the status of this pls? Whilst not the current version of stylelint (16.2.1), it seems like this would be a step in the right direction. I've not found any combination of packages that work with the betterer stylelint test and the stylelint configs stylelint-config-standard and stylelint-config-standard-scss which is preventing me from making use of betterer.

If we could work towards using the latest version of stylelint as a peer dependency, that would be ideal.

adrianbruntonsagecom avatar Mar 15 '24 18:03 adrianbruntonsagecom