bsp-layout icon indicating copy to clipboard operation
bsp-layout copied to clipboard

Inconsistent behavior with --master-size flag

Open marcxjo opened this issue 8 months ago • 0 comments

What did you expect to happen?

When I set a layout with the --master-size flag set, I expect the master window to occupy a section of the window that takes up that percentage of the area.

What actually happened?

I ran the following sequence of commands on a workspace called I. Before the tall layout was set, the workspace was configured with default bspwm tiling behavior. The workspace was typically tested with a configuration of four terminal windows (hence measurements below given in terms of monospace characters.)

  • bsp layout set tall I -- --master-size 0.3 The layout is configured, with no change to the dimensions of the designated master window. All other windows on screen are arranged vertically in the space not occupied by the master window.
  • bsp layout set tall I -- --master-size 0.6 No visible change occurs.

Trying again with a fractional representation of the same value:

  • * bsp layout set tall I -- --master-size 3/10` The master window width is decreased to a width of approximately 1 monospace character. The stacked windows are all stretched to occupy the remaining screen width.

  • * bsp layout set tall I -- --master-size 6/10` The window stack width is decreased to a width of approximately 1 monospace character. The master window is stretched to occupy the remaining screen width.

Describe your attempts to resolve the issue

I reverted the removal of bc to handle the calculation of the master window size. This appears to be the fix; I'll push a PR shortly after posting this bug.

Steps to reproduce

See the above answer to the question "What actually happened?"

System Information

Installed bsp-layout using a modified AUR PKGBUILD to use latest master commit.

OS arch:

$ uname -osrm
Linux 6.9.4-arch1-1 x86_64 GNU/Linux

marcxjo avatar Jun 16 '24 02:06 marcxjo