bsp-layout icon indicating copy to clipboard operation
bsp-layout copied to clipboard

kill subscriber process when desktop is removed

Open amtoine opened this issue 3 years ago • 5 comments

This is a duplicate of the stale #36 to apply the requested changed and merge the branch to master.

amtoine avatar Jul 09 '22 08:07 amtoine

TODO:

amtoine avatar Jul 09 '22 08:07 amtoine

@phenax would you like me to apply the changes above from the original PR, without a review? or wrap them inside a review first?

no pressure if you do not have the time, that's just a friendly ping :relieved:

amtoine avatar Aug 09 '22 16:08 amtoine

@amtoine, I think it's better if this pr contains those changes before the review if that's what you mean

phenax avatar Aug 09 '22 16:08 phenax

@amtoine, I think it's better if this pr contains those changes before the review if that's what you mean

it was my question :yum:

so i'll add the changes and ping you when i'm done :wink:

amtoine avatar Aug 09 '22 16:08 amtoine

@phenax the first point should be addressed in b38e145c and the second in 3186fc79 :yum: EDIT: and a bad typo below :eyes:

review can begin :muscle:

amtoine avatar Aug 12 '22 10:08 amtoine