starshot-prototype
starshot-prototype copied to clipboard
phenaproxima
Create a Card block content type
This is part of #12.
In a one-on-one chat, @larowlan and I felt that it would be a good idea to start adding some useful block types, even though we don't quite have a page layout system in Starshot yet. A card block type seems useful because, even if we don't have a decent layout system, cards might still make sense in the sidebar in some situations. There's no harm in building out the data model/fields now, even without any special affordance for layout.
I think we should also think about a 'card reference' block type recipe (Separate PR)
@larowlan, can you open a separate issue or PR for that?
As of #77, I think we might want to start using Type Tray for the block types, and ship some icons.
There are a couple of things about this PR that I'm not sure I understand. For starters, I've heard that the intent for XB is to use something other than blocks or paragraphs, likely some new kind of entity intended to incorporate the best of both former approaches.
Also, when I've personally created "cards" during site builds, it has been as a display mode. In other words, my view is that the concept of "card" is more about how to display information than what is being displayed. So I could display an event as a card, a person as a card, even a CTA as a card, but I don't know that people will have a uniform idea of what a generic "card" would contain.
@mandclu keep in mind that XB will not be ready for the initial Starshot release, so in the meantime I think we will have to use blocks for some elements. I agree often cards are view modes, but there are definitely cases where you want a card element while you are building a page that is not a reference to another entity. But I don't think we want to approach it piecemeal, we should document the content model for Starshot first and then determine whether a card is needed.
Just to update here: I think this should be closed as "too soon".
It makes sense to me to wait on the beginnings of a design system before we start creating block types. Although my inner site builder still feels like a Card block type is a no-brainer, it also doesn't make much sense to add it until we have some sort of way for cards to be used in a page build-out. (That's what I take away from @mandclu's comment in https://github.com/phenaproxima/starshot-prototype/pull/76#issuecomment-2186060082.) @pameeela's point is also well-taken. Let's add this later as part of a coherent model for building pages.