starshot-prototype icon indicating copy to clipboard operation
starshot-prototype copied to clipboard

The Event content type should use Smart Date fields, not datetime_range

Open mandclu opened this issue 9 months ago • 5 comments

As per the discussion in #64, convert the Event content type to use a Smart Date field, and set the default value to "next hour".

mandclu avatar May 13 '24 18:05 mandclu

Just FYI -- I cannot merge this because it's not installing. This is the error we're getting: https://github.com/phenaproxima/starshot-prototype/actions/runs/9071250306/job/24967409796?pr=69#step:5:791

Probably some misconfiguration in the fields. @mandclu, if you can address this I or another maintainer can manually test and hopefully merge this.

phenaproxima avatar May 16 '24 01:05 phenaproxima

OK I'll try to have a look tomorrow

mandclu avatar May 16 '24 01:05 mandclu

I believe the issue was the field values in the demo content. I added a commit to convert them.

mandclu avatar May 16 '24 05:05 mandclu

Looks like there's a bug in the module here, @mandclu...bad enough that it prevents installation. Can you address that? I'll need to at least manually test this before I can merge it.

phenaproxima avatar May 24 '24 20:05 phenaproxima

I added a commit and then tested the result on a fresh install. The updated recipe worked without issue for me.

mandclu avatar May 25 '24 10:05 mandclu

I think this needs to be rebased against main.

phenaproxima avatar Jun 21 '24 19:06 phenaproxima