starshot-prototype icon indicating copy to clipboard operation
starshot-prototype copied to clipboard

A few anomalies after switching from Gin and Navigation to Claro and Admin Toolbar

Open gitressa opened this issue 1 year ago • 6 comments

The current combination is Gin and Navigation, but I prefer Claro and Admin Toolbar, which could be the most common combination. I just tried it, and found these anomalies:

  1. Headers are shown under Admin Toolbar
  2. "Announcements" is included in the menu
  3. "Configuration" menu item has been moved a few steps to the right (lower)

Starshot-Claro-Admin-Toolbar-headers-shown

gitressa avatar Jul 31 '24 13:07 gitressa

Can you reproduce this with plain core? If so, this isn't in Starshot's scope...it doesn't look, on its face, like a bug in the prototype, but if you can't reproduce it with core I'm happy to look into it further.

phenaproxima avatar Jul 31 '24 14:07 phenaproxima

Thanks for a fast reply. I tried installing Drupal 10, enabling Gin and Navigation, and then uninstalling and replacing them with Claro and Admin Toolbar, and everything works as expected.

I then tried the same with a fresh Starshot install, and the bug was replicated. Here are the steps for faster replication:

  • drush config:set system.theme admin claro -y
  • composer require drupal/admin_toolbar
  • drush in admin_toolbar admin_toolbar_tools admin_toolbar_search
  • drush un navigation
  • drush cache:rebuild

gitressa avatar Jul 31 '24 15:07 gitressa

Interesting - thanks for the clear steps to reproduce! That's quite curious indeed.

phenaproxima avatar Jul 31 '24 15:07 phenaproxima

You're welcome! Did you see the same behaviour?

gitressa avatar Jul 31 '24 19:07 gitressa

drush config:set system.theme admin claro -y

@gitressa, question: did you run drush then claro (or otherwise install Claro at /admin/appearance) before this?

phenaproxima avatar Aug 01 '24 16:08 phenaproxima

I did not run that command, and if you check under /admin/appearance, Claro is listed under "Installed themes", in a fresh Starshot install.

I simply install Starshot, and run those five Drush commands.

gitressa avatar Aug 03 '24 13:08 gitressa