phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

Update strings.js

Open ViktorOn opened this issue 2 years ago • 10 comments

Changes:

  • Many translation fixes
  • Bug fixes, typos and other shortcomings

ViktorOn avatar Aug 03 '22 18:08 ViktorOn

Error: Contributor Licence Agreement Signature Missing

Please sign the Contributor Licence Agreement by clicking the following link.

Click here to sign the CLA

### Error: Contributor Licence Agreement Signature Missing The following commiter(s) has not signed the Contributor Licence Agreement: ViktorOn Please sign the Contributor Licence Agreement by clicking the following link.

Click here to sign the CLA

phoenixide avatar Aug 04 '22 06:08 phoenixide

Thanks a lot for contributing to Phoenix :) @ViktorOn Please sign the CLA to merge these changes: https://phcode-dev.github.io/contributor-license-agreement/

abose avatar Aug 04 '22 06:08 abose

Error: Contributor Licence Agreement Signature Missing

Please sign the Contributor Licence Agreement by clicking the following link.

Click here to sign the CLA

### Error: Contributor Licence Agreement Signature Missing The following commiter(s) has not signed the Contributor Licence Agreement: ViktorOn Please sign the Contributor Licence Agreement by clicking the following link.

Click here to sign the CLA

phoenixide avatar Aug 04 '22 07:08 phoenixide

Thanks a lot for contributing to Phoenix :) @ViktorOn Please sign the CLA to merge these changes: https://phcode-dev.github.io/contributor-license-agreement/

Doesn't the license (AGPL-3.0) provide for the ability to change/distribute the code after editing?

ViktorOn avatar Aug 10 '22 21:08 ViktorOn

The CLA is different from the AGPL license.

CLA means that you as the author grants right to Phoenix to use the code you contribute under the AGPL License. Without the CLA, we assume that we do not have your consent to mark the code you provided as AGPL.

This only needs to be done once. After signing, under  (AGPL-3.0), anyone will have ability to change/distribute the code after editing.

abose avatar Aug 11 '22 09:08 abose

Error: Contributor Licence Agreement Signature Missing

Please sign the Contributor Licence Agreement by clicking the following link.

Click here to sign the CLA

### Error: Contributor Licence Agreement Signature Missing The following commiter(s) has not signed the Contributor Licence Agreement: ViktorOn Please sign the Contributor Licence Agreement by clicking the following link.

Click here to sign the CLA

phoenixide avatar Aug 11 '22 10:08 phoenixide

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

sonarqubecloud[bot] avatar Aug 11 '22 10:08 sonarqubecloud[bot]

Hi @ViktorOn Got any time to look at the CLA? Waiting on it to merge.

abose avatar Sep 06 '22 12:09 abose

Hi @ViktorOn Got any time to look at the CLA? Waiting on it to merge.

I have read this agreement, but I will not sign it. If you want, here I grant you the right to make these changes to the code and use it under the AGPLv3 license

ViktorOn avatar Sep 07 '22 09:09 ViktorOn

Hi @ViktorOn Got any time to look at the CLA? Waiting on it to merge.

I have read this agreement, but I will not sign it. If you want, here I grant you the right to make these changes to the code and use it under the AGPLv3 license

Hi @ViktorOn Thanks for the update.

We copied the same terms from Adobe's CLA from brackets before. Are there any concerns about the CLA so that i can review the concerning terms?

Almost all OSS projects have project specific CLAs, Attached other CLAs for reference: https://www.apache.org/licenses/contributor-agreements.html https://openjsf.org/about/the-openjs-foundation-cla/ https://github.com/brackets-cont/contributor-license-agreement

abose avatar Sep 10 '22 11:09 abose

Archiving PR due to inactivity.

abose avatar Nov 12 '22 12:11 abose