phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

enhancement: searching in a different file than the opened one needs more visibility

Open mathewdennis1 opened this issue 2 years ago • 2 comments

Describe the bug It could be a good idea to make it a bit more clear that we are searching in a different file than what we have opened..(people could accidentally right-click on a different file and won't realise it ..) To Reproduce Steps to reproduce the behavior:

  1. open a file right click and select find function
  2. right click on a different file to search
  3. see that it is very difficult to recognise that we are searching in a different file

Expected behavior A clear indication that we are searching in a different file. Screenshots

177122401-6bdd2f3a-c3bb-41bd-a77

video -->https://user-images.githubusercontent.com/78793827/177122401-6bdd2f3a-c3bb-41bd-a779-7fbadf5c58fe.mp4

mathewdennis1 avatar Jul 04 '22 09:07 mathewdennis1

This is expected behavior currently and requires UX analysis and enhancement to address properly.

  • Currently there is an indication what file is being searched in the search bar itself image
  • The user has to explicitly left click on the file to search within a file and it deliberately doesn't switch to the file, this workflow is specifically to not take focus out of the current file. If a user wish to see the file, they need to explicitly click to open file and search.

As these are two different intents, it is safe to assume that the workflow need not be worked upon at this time. Closing as expected behavior.

abose avatar Jul 04 '22 13:07 abose

I would like to recommend a small enhancement ,something like in the image below, when searching in other files.. (a popup bar on top that would only show if we are searching in other files .if not we get the default behaviour)

  • this will give a visual confirmation that ,we are actually searching in another file
  • especially significant if there are large number of files with similar name .

image

image

mathewdennis1 avatar Jul 04 '22 13:07 mathewdennis1

This is now fixed with: https://github.com/phcode-dev/phoenix/pull/1531 Thanks for the suggestion @mathewdennis1

abose avatar Apr 04 '24 12:04 abose