console
console copied to clipboard
Secret changes dialog added #274
:mag: Overview
- This pull request solves issue #274.
- Feature: Functionality which allows user to see the changes made to environment secrets.
:bulb: Proposed Changes
- Used GenericDialog component to show the changes made by user
- Added info button which onClick shows dialog
- Created type SecretChange for the secret changes
- Created a component DisplayChanges which returns changes of a particular secret
- Also limited key value to 50 characters so that it does overflow out of the dialogue
:framed_picture: Screenshots or Demo
Before
After
:memo: Release Notes
User now can see the changes made to the environment secrets
:question: Open Questions
Is there anyway I can enhance the UI more?
:test_tube: Testing
- Add a secret
- Change an attribute of a pre-existing secret
- Remove a tag from the secret and add other tags
:dart: Reviewer Focus
You can just make any desired changes and click on the info button to view the changes
:heavy_plus_sign: Additional Context
issue #274
:sparkles: How to Test the Changes Locally
- Pull the branch
- log in to your phase console account
- head over to an environment of any app and start testing
:green_heart: Did You...
- [x] Ensure linting passes (code style checks)?
- [ ] Update dependencies and lockfiles (if required)
- [ ] Regenerate graphql schema and types (if required)
- [ ] Verify the app builds locally?
- [x] Manually test the changes on different browsers/devices?