console icon indicating copy to clipboard operation
console copied to clipboard

Add a menu / screen to manage tags

Open rohan-chaturvedi opened this issue 1 year ago • 9 comments

Is your feature request related to a problem?

Currently tags can be created organisation wide, but cannot be edited or deleted.

Describe the solution you'd like

A screen that allows editing and deleting tags. UI inspiration:

Screenshot from 2023-11-18 14-21-10

rohan-chaturvedi avatar Nov 18 '23 08:11 rohan-chaturvedi

I would like to work on this issue!! @rohan-chaturvedi

SuryatejPonnapalli avatar Jul 08 '24 04:07 SuryatejPonnapalli

I would like to work on this issue!! @rohan-chaturvedi

Sure, its all yours!

rohan-chaturvedi avatar Jul 08 '24 07:07 rohan-chaturvedi

Screenshot 2024-07-27 at 12 41 00 PM

@rohan-chaturvedi is it fine if I keep tags manage button here? or should I try to put it somewhere in the tagsDialgue? and also is there any query to edit or delete a tag?

SuryatejPonnapalli avatar Jul 27 '24 07:07 SuryatejPonnapalli

@SuryatejPonnapalli let's put it in the tags dialog, in a separate "Manage tags dialog". You'll need to add queries and mutations to edit and delete tags.

rohan-chaturvedi avatar Jul 27 '24 07:07 rohan-chaturvedi

Screenshot 2024-07-27 at 4 02 54 PM Screenshot 2024-07-27 at 4 03 22 PM

@rohan-chaturvedi is this UI fine to manage tags? Actually am not familiar with drf/graphQL, can you share any reference/docs that I can look into to write new queries and mutations?

SuryatejPonnapalli avatar Jul 27 '24 10:07 SuryatejPonnapalli

That looks great! How will the edit action work?

Fastest way to get familiar with mutations is to check out how existing ones are written, such as the CreateSecretTagMutation. Write a similar mutation for edit and delete, and add them to the schema

You can also check out the docs for Graphene Django

rohan-chaturvedi avatar Jul 27 '24 11:07 rohan-chaturvedi

onClick it will open a modal in which user has option to edit the tag and on confirming the change, it will get updated. do you have any other suggestions or requirements in your mind?

SuryatejPonnapalli avatar Jul 27 '24 11:07 SuryatejPonnapalli

That could work, except we are already using a modal nested in another modal :sweat_smile:

What if we allowed editing the tag name and color in place? In your UI, clicking the 'edit' button would make the tag text editable, and allow clicking the color dot to open the color picker. If any changes have been made to a tag, replace the 'edit' button with a 'save' button to save changes.

rohan-chaturvedi avatar Jul 27 '24 11:07 rohan-chaturvedi

thanks for the suggestion ill try to implement it.

SuryatejPonnapalli avatar Jul 27 '24 11:07 SuryatejPonnapalli