p2-theme-core icon indicating copy to clipboard operation
p2-theme-core copied to clipboard

Published 20 hours ago • verified publisher icon phase2

Icon font uses an incorrect "appendUniconde" option

Open recrit opened this issue 3 years ago • 1 comments

Issue The "appendUniconde" is spelled wrong and should have been "appendUnicode", so it was never being used anyways. The new option for "gulp-svgicons2svgfont" is "prependUnicode", see changes in https://github.com/nfroidure/gulp-svgicons2svgfont/issues/33.

See https://github.com/nfroidure/gulp-svgicons2svgfont " options.prependUnicode Type: Boolean Default value: false

Allow to prepend unicode codepoints to icon file names in order to always keep the same codepoints accross each run "

This leads to inconsistent codepoints on subsequent builds which leads to incorrect icons displayed for browsers thats really like to cache icon files even with a cache bust query string.

Affected Versions All versions.

recrit avatar Jul 15 '21 20:07 recrit

The PR https://github.com/phase2/p2-theme-core/pull/57 is for the 9.x version but this needs fixed in all versions.

recrit avatar Jul 16 '21 14:07 recrit