generator-gadget icon indicating copy to clipboard operation
generator-gadget copied to clipboard

Update zombie version for NodeJS 8.x

Open csegarra opened this issue 7 years ago • 3 comments

After updating NodeJS to the las version (8.9.4), npm can't install the zombie package because it fails to download the dependencies.

It appears that the problem was that the contextify package can't be build.

gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:258:23)
gyp ERR! stack     at emitTwo (events.js:126:13)
gyp ERR! stack     at ChildProcess.emit (events.js:214:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
gyp ERR! System Linux 4.9.0-5-amd64
gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /tmp/gadget-error/node_modules/contextify
gyp ERR! node -v v8.9.4
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

The problem appears to be solved with the current version of the zombie package.

csegarra avatar Jan 08 '18 19:01 csegarra

Hi there, and thanks for the contribution. I'm still trying to get time together to fix blocking tests, and am planning to have a light breaking change for Node 8 support with the current raft of PRs. We're moving in teh direction of Phantom.js rather than Zombie to solve the Node 8 compatibility problem and better align with the larger Drupal community.

It is interesting you got Zombie to update, in practice (and this is a 2 year outdated "practice"), we found updated version of Zombie had deep failures when trying to execute the tests.

I will put together a release planning issue to better clarify the current plan.

grayside avatar Jan 08 '18 19:01 grayside

Follow-up: Interestingly enough, this passed tests.

grayside avatar Jan 08 '18 19:01 grayside

Aha! This is the generator project, not grunt-drupal-tasks. That explains it :) This project does not test the behat execution.

grayside avatar Jan 08 '18 19:01 grayside