generator-gadget icon indicating copy to clipboard operation
generator-gadget copied to clipboard

Add profile

Open mike-potter opened this issue 8 years ago • 6 comments

Initial attempt to add a prompt for the Profile to be generated.

  1. Only prompts for this if an 8.x distro version is selected (either Drupal or Octane)
  2. Defaults to projectName
  3. Couldn't figure out how you enter a "blank" value when specifying a default, so using "none" as the answer to skip the profile generation. There is probably a better way to do this.
  4. Using two new templates in templates/profile to generate the profile.

mike-potter avatar Aug 16 '17 15:08 mike-potter

(FYI, sorry I created this initially form the add-config-directory branch, but I removed that commit here so this isn't dependent on the other PR. Just made the commit log messier)

mike-potter avatar Aug 16 '17 15:08 mike-potter

The src/config piece is just a branch for now, got it started on the idea that it wasn't ready for PR until someone adds the symlink task.

grayside avatar Aug 18 '17 02:08 grayside

Also left out of the review, we should add a test case for opting into the profile and confirming the profile files are created.

grayside avatar Aug 18 '17 02:08 grayside

@mike-potter various updates to the branch, please review.

The new machine name validation I did by hand, here are my test cases: https://regex101.com/r/rvbdMN/1/tests

grayside avatar Sep 08 '17 05:09 grayside

Agree that Gruntconfig needs to be updated. Otherwise it looks good, but I didn't have time to actually run the test.

mike-potter avatar Sep 08 '17 20:09 mike-potter

  • [ ] Add a comment what config_install comes from.

grayside avatar Sep 12 '17 20:09 grayside