Allow to move an image file

[npasserini]

Local git repos in iceberg-cache should keep being valid, either because they have been moved with the image or because we re-create the local clones from their remote counterparts.

Other git repos (with absolute file locations) will be expected to be in the same place, regardless of the image being moved.

[guillep]

We should test better non-bound repositories

[seandenigris]

The fix seems simple. Edit this one method as follows to not resolve:

IceLibgitRepository >> #localRepositoriesLocation
	^ FileLocator localDirectory / #iceberg

PR incoming...

[seandenigris]

Not sure how to do the PR @estebanlm @guillep. If I add this as a remote repo in P8, many unrelated changes show up before I do anything...

[guillep]

hi Sean, the version of iceberg in pharo 8 is iceberg 1.6. Would you mind trying with that branch?

Le ven. 4 oct. 2019 à 19:27, Sean DeNigris [email protected] a écrit :

Not sure how to do the PR. If I add this as a remote repo in P8, many unrelated changes show up before I do anything...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pharo-vcs/iceberg/issues/26?email_source=notifications&email_token=AAFM5YRS5B4BRKG33Q3UE2LQM54JLA5CNFSM4CERY7CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAMLCHY#issuecomment-538489119, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFM5YXKYOJJJ6QG3Y42P53QM54JLANCNFSM4CERY7CA .

[seandenigris]

When trying to check out that branch, it shows quite a few changes in Pharo 8:

Bump, @estebanlm @guillep

[seandenigris]

@estebanlm @guillep Bump!! It would be nice to fix this in time for P8 :)

[seandenigris]

@tesonep's merge seems to have fixed this. Can someone close it?