iceberg icon indicating copy to clipboard operation
iceberg copied to clipboard

"Force commit" button should be called "Commit" once critiques is solved

Open astares opened this issue 2 years ago • 0 comments

When one commits a package in Pharo Iceberg runs the lint rules and shows code critiques. The user has two options:

  • either use a button "Force commit" to commit without fixing the lint issues
  • or browse the issues and fix them

Typically users should clean their code and they can use an "Update" button to run the lint checks again and see if there are still critiques left.

Once all critiques are gone the button to commit to the repo is still called "Force commit" which is then confusing as one does not have to force the commit anymore - just perform it.

So when the "Update" button runs the checks again the button label for the middle button should be set to:

  • "Force commit" when there are still critiques detected
  • "Commit" when no critiques are detected anymore

This would be more user friendly image

Side note: Note that if the critiques list is empty and the Update triggers a renaming from "ForceCommit" to "Commit" it can also happen that the dialog is not closed and a new lint problem is introduced. In such a case the Update should rename back from "Commit" to "Force commit".

astares avatar Nov 27 '22 23:11 astares