Fix Pharo's #11370

[guillep]

We also generate the definition for the metaclass (See visitMetaclass…Definition: comment).

We need both the instance and class side class nodes so they can contain their corresponding methods (that are visited in a random order) => Generate the class side definition always. If it turns out to be empty, it is filtered out later Fix https://github.com/pharo-project/pharo/issues/11370

[Ducasse]

HI guille

several iceberg tests are broken. I do not know if they are related.

[guillep]

I will check. I'm not sure what is the state of the tests right now. Probably they miss an update. They were a bit abandoned because they were on travis.

[guillep]

I'll check this one today

[guillep]

Tests are running in P11, in P10 there seems to be an incompatibility with how we use fuel in P10

IceCredentialStoreTest
 ✗ #testSaveAndLoadEmptyStore (189ms)
Instance of FLSerializer did not understand #onStream:
FLSerializer(Object)>>doesNotUnderstand: #onStream:
[ :stream | 
			FLSerializer new
				onStream:  stream;
				object: {plainCredentials. sshCredentials};
				serialize ] in IceCredentialStore>>saveIntoStore
[ aBlock value: stream ] in FileReference(AbstractFileReference)>>binaryWriteStreamDo:
FullBlockClosure(BlockClosure)>>ensure:
FileReference(AbstractFileReference)>>binaryWriteStreamDo:
IceCredentialStore>>saveIntoStore
IceCredentialStoreTest>>testSaveAndLoadEmptyStore ...saveIntoStore
IceCredentialStoreTest(TestCase)>>performTest
 ✗ #testStoreInNonExistingDirectory (82ms)
Instance of FLSerializer did not understand #onStream:
FLSerializer(Object)>>doesNotUnderstand: #onStream:
[ :stream | 
			FLSerializer new
				onStream:  stream;
				object: {plainCredentials. sshCredentials};
				serialize ] in IceCredentialStore>>saveIntoStore
[ aBlock value: stream ] in FileReference(AbstractFileReference)>>binaryWriteStreamDo:
FullBlockClosure(BlockClosure)>>ensure:
FileReference(AbstractFileReference)>>binaryWriteStreamDo:
IceCredentialStore>>saveIntoStore
IceCredentialStoreTest>>testStoreInNonExistingDirectory ...saveIntoStore
IceCredentialStoreTest(TestCase)>>performTest
 ✗ #testStoreInNonExistingFile (175ms)
Instance of FLSerializer did not understand #onStream:
FLSerializer(Object)>>doesNotUnderstand: #onStream:
[ :stream | 
			FLSerializer new
				onStream:  stream;
				object: {plainCredentials. sshCredentials};
				serialize ] in IceCredentialStore>>saveIntoStore
[ aBlock value: stream ] in FileReference(AbstractFileReference)>>binaryWriteStreamDo:
FullBlockClosure(BlockClosure)>>ensure:
FileReference(AbstractFileReference)>>binaryWriteStreamDo:
IceCredentialStore>>saveIntoStore
IceCredentialStoreTest>>testStoreInNonExistingFile ...saveIntoStore
IceCredentialStoreTest(TestCase)>>performTest
 ✗ #testStorePlainTextSavingInFile (181ms)
Instance of FLSerializer did not understand #onStream:
FLSerializer(Object)>>doesNotUnderstand: #onStream:
[ :stream | 
			FLSerializer new
				onStream:  stream;
				object: {plainCredentials. sshCredentials};
				serialize ] in IceCredentialStore>>saveIntoStore
[ aBlock value: stream ] in FileReference(AbstractFileReference)>>binaryWriteStreamDo:
FullBlockClosure(BlockClosure)>>ensure:
FileReference(AbstractFileReference)>>binaryWriteStreamDo:
IceCredentialStore>>saveIntoStore
IceCredentialStore>>storeCredential:forHostname:
IceCredentialStoreTest>>testStorePlainTextSavingInFile ...storeCredential: orig forHostname: 'github.com'
IceCredentialStoreTest(TestCase)>>performTest
 ✗ #testStoreTokenSavingInFile (184ms)
Instance of FLSerializer did not understand #onStream:
FLSerializer(Object)>>doesNotUnderstand: #onStream:
[ :stream | 
			FLSerializer new
				onStream:  stream;
				object: {plainCredentials. sshCredentials};
				serialize ] in IceCredentialStore>>saveIntoStore
[ aBlock value: stream ] in FileReference(AbstractFileReference)>>binaryWriteStreamDo:
FullBlockClosure(BlockClosure)>>ensure:
FileReference(AbstractFileReference)>>binaryWriteStreamDo:
IceCredentialStore>>saveIntoStore
IceCredentialStore>>storeCredential:forHostname:
IceCredentialStoreTest>>testStoreTokenSavingInFile ...storeCredential: original forHostname: 'github.com'
IceCredentialStoreTest(TestCase)>>performTest

[guillep]

Tests are green, all but in windows, one timeout, and one other error I don't know... @tesonep