iceberg icon indicating copy to clipboard operation
iceberg copied to clipboard

DNU in IceCritiquesVisitor (IceCritiquesVisitor did not understand #visitDirectoryDefinition:)

Open astares opened this issue 2 years ago • 2 comments

I tried this in Pharo 10 release:

  • create a project in Github (with a README and MIT License) and then clone it locally using Iceberg this means there is no .project metainformation for Pharo in it yet
  • now you want a "src" subdirectory, so in Iceberg click on "Repair" button, define a "src" directory for your source code and choose "Tonel" for the file format in the Iceberg dialog

Now in the commit dialog you get:

image

and when you hit "Commit" a debugger opens:

image

I guess this is because the critiques had been added to Iceberg in Pharo 10 iteration and the visitor is not able to handle the directory definition.

astares avatar May 31 '22 06:05 astares

Implement it as an empty method in class IceCritiquesVisitor in category "visiting" easily fixes this:

visitDirectoryDefinition: anIceDirectoryDefinition 
	"Nothing to do here"

image

astares avatar May 31 '22 06:05 astares

Implement it as an empty method in class IceCritiquesVisitor in category "visiting" easily fixes this:

I'm new to GToolkit/Pharo/Smalltalk and you just saved my day. I have watched a few tutorial videos and got stuck here due to that error. I don't really even know what happened other than bypassing this feature.

cminter avatar Aug 26 '22 05:08 cminter