Cannot add remote when checkout branch from issue

[demarey]

Get #entity was sent to nil when trying to add a remote from the "checkout new branch from issue" panel. To reproduce (in Pharo 8):

• on a repository, select "checkout branch"
• then select "new branch from issue"
• then click on the '+' button aside the remote

stack trace:

UndefinedObject(Object)>>doesNotUnderstand: #entity
UndefinedObject>>doesNotUnderstand: #entity
IceTipRemoteActionModel>>useRemote:
IceGitHubNewBranchFromIssuePanel>>useRemote:
[ :remoteModel | self useRemote: remoteModel ] in IceGitHubNewBranchFromIssuePanel>>initializeWidgetsContents in Block: [ :remoteModel | self useRemote: remoteModel ]
BlockClosure>>cull:
BlockClosure>>cull:cull:
BlockClosure>>cull:cull:cull:
BlockClosure>>cull:cull:cull:cull:
[ :new :old :announcement :ann | 
aBlock
	cull: (new ifNotNil: [ :item | item model ])
	cull: old
	cull: announcement
	cull: ann ] in DropListPresenter>>whenSelectedItemChanged: in Block: [ :new :old :announcement :ann | ...
BlockClosure>>cull:cull:cull:cull:
[ :announcement :ann | 
aBlock
	cull: announcement newValue
	cull: announcement oldValue
	cull: announcement
	cull: ann ] in NewValueHolder(Model)>>whenChangedDo: in Block: [ :announcement :ann | ...
BlockClosure>>cull:cull:
[ action cull: anAnnouncement cull: announcer ] in AnnouncementSubscription>>deliver: in Block: [ action cull: anAnnouncement cull: announcer ]
BlockClosure>>on:do:
BlockClosure>>on:fork:
AnnouncementSubscription>>deliver:
[ "Ensure delivery to remaining announcements" subscription deliver: anAnnouncement ] in SubscriptionRegistry>>deliver:to:startingAt: in Block: [ "Ensure delivery to remaining announcements" sub...etc...
BlockClosure>>ifCurtailed:
SubscriptionRegistry>>deliver:to:startingAt:
SubscriptionRegistry>>deliver:to:
SubscriptionRegistry>>deliver:
Announcer>>announce:
NewValueHolder>>valueChanged:to:
NewValueHolder>>valueChanged:
[ | oldValue |
oldValue := value.
value := anObject.
self valueChanged: oldValue ] in NewValueHolder>>value: in Block: [ | oldValue |...
BlockClosure>>ensure:
NewValueHolder>>handleCircularReferencesWhile:
NewValueHolder>>value:
SelectionValueHolder>>reset

[guillep]

I just tried it and I cannot reproduce it in Pharo8 nor Pharo9.

Please, give more information if possible.

[demarey]

I just downloaded a fresh P8 and followed the given instructions. The problem is still there. To reproduce (in Pharo 8):

• open iceberg
• clone pharo-project/pharo-launcherfrom github
• select pharo-launcher repo, then right-click and select "checkout branch"
• then select "new branch from issue"
• then click on the '+' button aside the remote
• add remote name: foo, remore url [email protected]:demarey/pharo-launcher.git
• click ok => error

I cannot re-open the issue myself

[guillep]

Ah good to know! By original instructions I thought that the error happened when clicking on the + button. Thanks!

[kevca87]

I have proved this in Pharo 12 and I get the same Issue. Platform:

• Windows 11 Home (Version 22H2).

@guillep

The steps that I follow were:

• In "New branch from issue" click "+" in the Remote field.
• In the "Add Remote" window copy "https://github.com/pharo-project/pharo" into Remote URL and fill the RemoteName field.
• Click in "Ok".

And the result will be:

The expected result is:

• "Add Remote" closes and the selected remote in "New branch from issue window" is the added remote.