iceberg icon indicating copy to clipboard operation
iceberg copied to clipboard

Why is there 2 "browse repository version"

Open hogoww opened this issue 4 years ago • 7 comments

when right clicking on a package in a repository, and using two differents GUI

hogoww avatar Jan 09 '20 09:01 hogoww

What exactly do you mean. Which Pharo version are you using? Can you provide a screenshot?

Can you please be more specific with your bug description?

astares avatar Jan 09 '20 13:01 astares

Of course, sorry. Thought it was simple enough, but i realise it is not.

Last pharo 8 version, I'm not sure where to find Iceberg's. Screenshot 2020-01-09 at 14 47 55 as you can see on the screenshot, you have twice the same command, doing seemingly the same thing with 2 different tools

number 1 (behind) looks like a regular browser ( and seems to be one ) number 2 (in front) looks like a simplified browser to me Screenshot 2020-01-09 at 14 49 59

hogoww avatar Jan 09 '20 13:01 hogoww

On Thu, Jan 9, 2020 at 10:37 AM hogoww [email protected] wrote:

when right clicking on a package, and using two differents GUI

One of them uses the external browser that is a "simple" browser not really user friendly.

The second open a real calypso on a Ring model. It feels as if we are browsing code from the image.

The second can often break if the smalltalk model change but changes are not transmitted on Ring. If you find bugs on this one you can notify Pavel or open an issue on the Ring repository.

You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pharo-vcs/iceberg/issues/1333?email_source=notifications&email_token=ACIUGY6XA5M7FRE2FC2RETTQ43V4VA5CNFSM4KEVH7J2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IFABHLQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACIUGY5NZXVLMYD245R3FYLQ43V4VANCNFSM4KEVH7JQ .

-- Cyril Ferlicot https://ferlicot.fr

jecisc avatar Jan 09 '20 14:01 jecisc

I was mostly thinking to have at least two different names, such as Browse repository version Browse critical repository version (to follow convention of the debugger, but i don't think that's good :p) Just have a more explicit naming

hogoww avatar Jan 09 '20 14:01 hogoww

I think this is a case of "we were migrating and we stopped the work in the middle" :) Now, how to solve the issue, I don't know. Ideally, we will finish the calypso based one... but it will not be for Pharo8 so maybe the best solution is to hide it for the moment?

estebanlm avatar Jan 09 '20 21:01 estebanlm

I would just rename the second into "Browse repository version (Simple Browser" for the moment.

So the user sees that the item leads to different paths and can decide which browser he wants to use. It's not uncommen to provide different tool views on similar models.

astares avatar Jan 10 '20 07:01 astares

I just found the cause of this: Calypso is "injecting" the extra version through commander. The problem is that it was never intended to have that.

See the ClyIceberg*Command classes

guillep avatar May 29 '20 14:05 guillep