Slider presenter

[tinchodias]

• beHorizontal (default): doesn't work except when min=0 and max=1.
• beVertical doesn't work
• SpSliderPresenterBackendTest: only basic smoke tests + should end with "AdapterTest"

[tinchodias]

Like this, it works:

s := SpSliderPresenter new.
s min: 0.
s max: 1.
s quantum: 0.1.
s value: 0.3.
s open.

Like this, it is broken:

s := SpSliderPresenter new.
s min: 0.
s max: 10.
s quantum: 1.
s value: 3.
s open.

[tinchodias]

The effect of beVertical is really weird:

s := SpSliderPresenter new.
s min: 0.
s max: 10.
s quantum: 0.2.
s beVertical.
s open.

this is related to these sentences in SpMorphicSliderAdapter>>#buildWidget:

	self presenter isHorizontal ifFalse: [ 
		preWidget := TransformationMorph new asFlexOf: preWidget.
		preWidget transform withAngle: 90 degreesToRadians negated ].

---

Nevertheless, the Morphic slider changes its orientation automatically by comparing width/height, as shown in this capture: So, the presenter's orientation is ignored.

[tinchodias]

Another sub-issue: the adapter tolerates string values, including a special care about fractions. See SpMorphicSliderAdapter>>#value::

value: aValue

	| value |	
	value := aValue isNumber
		ifTrue: [ aValue ] 
		ifFalse: [ 
			(aValue includes: $/)
				ifTrue: [ (NumberParser on: aValue) nextFraction ]
				ifFalse: [ aValue asNumber ] ].

	^ self presenter value: value asFloat

This is candidate to be removed. Just accept numbers is a better option.

[Ducasse]

Yes please what a bad idea. May be it should also accept XML, YAML, Java and more! What a strange idea.

[tinchodias]

@Ducasse What is your opinion about orientation? 2 options:

• Remove beVertical and beHorizontal from the slider presenter API, and use the automatic orientation from the Morphic widget (and make other backends have this behavior)
• Remove the automatic orientation from Morphic widget and make beVertical and beHorizontal work.

Both presenter API orientation and automatic orientation are not possible at the same time.

@estebanlm ?

[tinchodias]

More in the presenter API to be fixed:

[tinchodias]

Another bug: SpSliderPresenter has this API, but has no effect on the widget:

addMark: aString at: aValue
	"Add the mark `aString` at `aValue` ."
	
	^ self marks: (self marks
		add: (SpSliderMark new
			value: aValue;
			text: aString;
			yourself);
		yourself)

at least it has no senders, and I tested it with:

s := SpSliderPresenter new.
s min: 0.
s max: 100.
s quantum: 1.
s value: 100.
s addMark: 'mid' at: 50.
s open.

[tinchodias]

Additionally, a slider can have a label. This works when set before open, but needs a manual action to trigger a refresh to show thie label when set after open:

s := SpSliderPresenter new.
s min: 0.
s max: 100.
s quantum: 1.
s value: 100.
s open.
s label: 'Label of Slider'.

[tinchodias]

Not included in #1619:

• SpSliderPresenter>>color:
• SpSliderPresenter's marks API
• vertical/horizontal property (the widget determines the orientation in base on width/height ratio)

[estebanlm]

hi, @tinchodias no, color: should not be fixed, it should be removed. color and that stuff needs to be defined through styles, not hardcoding it.

[tinchodias]

Thanks @estebanlm good point, I agree. I'm going to delete the color: method from SpSliderPresenter. No need to deprecate it as it is overriding an accessor from SpAbstractWidgetPresenter.

[tinchodias]

So, not yet included in https://github.com/pharo-spec/Spec/pull/1619:

• SpSliderPresenter's marks API --> I can't find any traces in the slider Morph of these marks
• vertical/horizontal property (the widget determines the orientation in base on width/height ratio)

I propose, for both cases, to remove the API. The alternatives would be a) to just deprecate instead of removing or b) implement it