pharo

pharo copied to clipboard

[Refactoring] conceptual limit/bug of addMethod refactoring

2

Imagine the following situation ``` A >> x ^ 33 B is empty C >> x ^ super x + 10 ``` Now we add a simple method x in...

Ducasse

Currently we have #classes/#classesDo:/#classesAndTraits/#classesAndTraitsDo: that are all returning classes and traits. We discussed with Steph and Marcus and we don't like it. Here is what we would like to get:...

jecisc

``` testBestNodeForReturnAStatementWhenIntervalInStatementWithoutLeftPart | ast start body | body := 'm | a | a := 1111111111111111. '. start := 'm | a | ' size. ast := (RBParser parseMethod: body)...

Ducasse

The method ``` getMethodString ^'toto "First comment" | temp variables | "Second comment" assignement := " Third comment " #node. "Fourth comment" message "Fifth comment", ''node''. "Sixth comment" cascade node;...

Ducasse

We should fix the rule description.

Ducasse

Progress Bar in Dark Theme does not have a good contrast

1

The progress of the system progress bar does not have a good contrast, it requires effort to see the advance of the job.

tesonep

[Refactorings] Bug on multiple application of RenameTemp (p12)

1

**Bug description** When you apply Rename temp twice in a row in the same method (for 2 different temps/parameters) - either it produces an error - or it is not...

NicolasAnquetil

It looks like the logic got lost in the migration to the new architecture.

Ducasse

- RBPullUpMethodTransformation should support the pull up even when behavior is modified - but it should not produce broken code. Code can be broken when: - Refer to instance variables...

Ducasse

``` A >> foo ^ self subclassResponsibility B C >> foo ^ 42 D >> foo ^ 666 ``` Pull Up D>> foo on A (with combo box) move self...

Ducasse