pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Windows edges grabbing for resizing not optimal

Open fedemennite opened this issue 4 years ago • 7 comments

Bug description There are a number of issues that make windows edges mouse grabbing for resizing problematic, especially on high resolution displays on Windows. The real fix would probably be to have Pharo to use the OS window manager. Alternatively one or more of the following suggestions could be evaluated/implemented

  • windows edges grab areas probably need to be slightly larger
  • it can quite easily happen that you end up grabbing the window for placement instead of grabbing it for resizing. Isn't the upper bar area of the window enough for that?
  • the resize cursor should also show up while over the edges of windows not currently having the focus Although not critical, this issue seems to have detrimental impact on productivity

To Reproduce Move the mouse over the edges of an open window, with or without focus

Expected behavior Windows should be easier to resize without requiring sniping skills ;)

Version information:

  • OS: Windows
  • Version: 10
  • Pharo Version 9

Expected development cost Medium to High

fedemennite avatar Apr 11 '21 23:04 fedemennite

Thanks for opening your first issue! Please check the CONTRIBUTING documents for some tips about which information should be provided. You can find information of how to do a Pull Request here: https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo

GitHub
Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk. - pharo-project/pharo

welcome[bot] avatar Apr 11 '21 23:04 welcome[bot]

@fedemennite @VincentBlondeau Can you tell me if you see an improvement with it? Thanks.

tesonep avatar Sep 09 '21 09:09 tesonep

  • the resize cursor should also show up while over the edges of windows not currently having the focus

Causes an unpleasant user experience. And still relevant (Pharo 10).

NSUSpray avatar Sep 16 '22 21:09 NSUSpray

Sorry but P10 is only get important updates. So if this is fixed in P11, then the issue is fixed.

Ducasse avatar Sep 17 '22 07:09 Ducasse

I also apologize, but now I checked in Pharo 11 and this issue is still there. Pharo-windows-edges

NSUSpray avatar Sep 17 '22 18:09 NSUSpray

thanks.

Ducasse avatar Sep 18 '22 08:09 Ducasse

I added two issues:

  • [ ] Forward port 9038 to Pharo 11: Windows edges grabbing for resizing not optimal https://github.com/pharo-project/pharo/issues/10347
  • [ ] Forward port 9038 to Pharo 10: Windows edges grabbing for resizing not optimal https://github.com/pharo-project/pharo/issues/11696

MarcusDenker avatar Sep 19 '22 08:09 MarcusDenker

fun fact, it sometimes changes the cursor for windows without focus

Pharo_GMut86MUTT

pavel-krivanek avatar Mar 15 '23 17:03 pavel-krivanek

The grips size is set by

EdgeGripMorph>>#defaultHeight
EdgeGripMorph>>#defaultWidth

The grip Morphs are invisible, it does not make the window border look bigger. The current values are 4, if set to 10, for example, it seems to work OK.

We could probalby overwrite these methods in WindowEdgeGripMorph and set create a new Setting.

pavel-krivanek avatar Mar 15 '23 18:03 pavel-krivanek

Hm, it will not be so easy because the it needs to adjust placement for right and bottom morph. This is how they look if I make them visible and partly transparent.

image

Then, for corners, it works differently. They are subclasses of CornerGripMorph and each of them handles in special way the mouse interaction, see BottomLeftGripMorph>>#containsPoint:. Their size is, by default, the SystemWindow borderWidth

pavel-krivanek avatar Mar 15 '23 18:03 pavel-krivanek