pharo icon indicating copy to clipboard operation
pharo copied to clipboard

(HDTestReport runSuite: PharoDocCommentTest suite) runAll

Open Ducasse opened this issue 3 months ago • 4 comments

(HDTestReport runSuite: PharoDocCommentTest suite) runAll

produces a report in progress.log that looks correct.

But it raises an error

next: amount putAll: aByteArray startingAt: startingIndex

	forWrite
		ifFalse: [ ^ self error: 'Cannot write a read-only file' ].
	[ File
		write: handle
		from: aByteArray
		startingAt: startingIndex
		count: amount ]
		on: PrimitiveFailed
		do: [ (FileWriteError fileName: self name)
				signal:
					(self closed
						ifTrue: [ 'File ' , self name , ' is closed' ]
						ifFalse: [ 'File ' , self name , ' write failed' ]) ].
	^ aByteArray

Ducasse avatar Nov 23 '25 11:11 Ducasse

Here is the contents of progress.log

running suite: PharoDocCommentTest
starting testcase: PharoDocCommentTest>>testAssociation ... finished in 0 seconds
starting testcase: PharoDocCommentTest>>testExpression ... finished in 3 milliseconds
starting testcase: PharoDocCommentTest>>testExpressionNoAssociation ... finished in 1 millisecond
starting testcase: PharoDocCommentTest>>testExpressionNoAssociation2 ... finished in 1 millisecond
starting testcase: PharoDocCommentTest>>testExpressionReferencingSelf ... finished in 0 seconds
starting testcase: PharoDocCommentTest>>testExpressionRuntimeError ... finished in 1 millisecond
starting testcase: PharoDocCommentTest>>testExpressionSyntaxError ... finished in 1 millisecond
starting testcase: PharoDocCommentTest>>testExpressionZero ... finished in 0 seconds
starting testcase: PharoDocCommentTest>>testMultipleDocComments ... finished in 0 seconds
starting testcase: PharoDocCommentTest>>testMultipleDocCommentsInOneComment ... finished in 0 seconds
starting testcase: PharoDocCommentTest>>testNestedComments ... finished in 0 seconds
starting testcase: PharoDocCommentTest>>testNestedInsanity ... finished in 1 millisecond
finished running suite: PharoDocCommentTest

Ducasse avatar Nov 23 '25 11:11 Ducasse

The problem comes from the fact that we need to call #run and not #runAll.

(HDTestReport runSuite: PharoDocCommentTest suite) run

This works. #runAll is not supposed to be call manually

jecisc avatar Nov 23 '25 13:11 jecisc

Because it bypasses the #setUp that is opening the stream

jecisc avatar Nov 23 '25 13:11 jecisc

Thank a lot cyril.

Ducasse avatar Nov 23 '25 14:11 Ducasse