pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Promote as package feature on a package tag does not move all tag's classes to the promoted package

Open LABSARI opened this issue 4 months ago • 4 comments

Bug description Promote as package feature/refactoring on a package tag does not move all classes to the promoted package.

To Reproduce Steps to reproduce the behavior:

  1. Open code browser and select a package (NewTools-Spotter for example)
  2. Inside the package, select a tag (the tag Model from NewTools-Spotter package for example)
  3. Right click -> Extra -> Promote as package
  4. The tag still contains classes that were not moved to the promoted package

Expected behavior It should move all classes from the tag to the promoted package and remove the tag that was promoted as a package.

Screenshots

Image

Version information:

  • OS: MacOS
  • Pharo 14

LABSARI avatar Oct 24 '25 14:10 LABSARI

Thanks for the report.

Ducasse avatar Oct 25 '25 18:10 Ducasse

Hi @Ducasse ! I'd like to work on this issue. Could you assign this to me?

R-Kri avatar Oct 29 '25 19:10 R-Kri

I assigned it.

I know this part of the system so I'll be able to review the change. It would be great to add regression tests also

jecisc avatar Oct 29 '25 19:10 jecisc

Hi @jecisc,

I'm working on reproducing this issue in Pharo 14. I've successfully set up my development environment and can navigate to the NewTools-Spotter package.

When testing the "Promote as package" feature on the Model tag, it appeared to work in my test. Could you point me to:

  1. The specific class/method that implements this refactoring
  2. Any existing tests for this feature
  3. A specific package/tag combination where the bug reliably reproduces

This will help me understand the expected behavior and write proper regression tests.

Image

Version information:

OS: MacOS Pharo 14

Thanks!

R-Kri avatar Nov 03 '25 13:11 R-Kri