Promote as package feature on a package tag does not move all tag's classes to the promoted package
Bug description Promote as package feature/refactoring on a package tag does not move all classes to the promoted package.
To Reproduce Steps to reproduce the behavior:
- Open code browser and select a package (NewTools-Spotter for example)
- Inside the package, select a tag (the tag Model from NewTools-Spotter package for example)
- Right click -> Extra -> Promote as package
- The tag still contains classes that were not moved to the promoted package
Expected behavior It should move all classes from the tag to the promoted package and remove the tag that was promoted as a package.
Screenshots
Version information:
- OS: MacOS
- Pharo 14
Thanks for the report.
Hi @Ducasse ! I'd like to work on this issue. Could you assign this to me?
I assigned it.
I know this part of the system so I'll be able to review the change. It would be great to add regression tests also
Hi @jecisc,
I'm working on reproducing this issue in Pharo 14. I've successfully set up my development environment and can navigate to the NewTools-Spotter package.
When testing the "Promote as package" feature on the Model tag, it appeared to work in my test. Could you point me to:
- The specific class/method that implements this refactoring
- Any existing tests for this feature
- A specific package/tag combination where the bug reliably reproduces
This will help me understand the expected behavior and write proper regression tests.
Version information:
OS: MacOS Pharo 14
Thanks!