pharo icon indicating copy to clipboard operation
pharo copied to clipboard

[RB] Bogus deprecation on StRefactoringPreviewPresenter

Open Ducasse opened this issue 5 months ago • 1 comments

for: aCompositeRefactoring scopes: scopes
	self deprecated: 'Use `for:scopes:` instead.' 
		on: '2024-01-20' 
		in: 'pharo13' 
		transformWith: '`@receiver changes: `@arg1 scopes: `@arg2' 
			-> '`@receiver for: `@arg1 scopes: `@arg2'.

	^ self new
		  changesFrom: aCompositeRefactoring scopes: scopes;
		  yourself

Ducasse avatar Jun 16 '25 08:06 Ducasse

There is something wrong

openPreviewWithChanges: changes

	^ (self previewPresenterClass for: changes scopes: scopes)
		  application: self application;
		  refactoring: self refactoring;
		  openModal

here is except changes as argument. The code is full of mixture between changes and refactoring :(

Ducasse avatar Jun 16 '25 08:06 Ducasse

Hello, We are looking at this. And we don't understand what is the issue.

luc-raz avatar Jun 27 '25 08:06 luc-raz

I think that I fixed it in P14. The API was totally strange.

Ducasse avatar Jun 27 '25 08:06 Ducasse