pharo icon indicating copy to clipboard operation
pharo copied to clipboard

pull up refactoring broken

Open demarey opened this issue 7 months ago • 1 comments

Trying to pull a class method on its super class, I get a DNU :(

Image

demarey avatar May 07 '25 08:05 demarey

ps: my superclass had already the same method

demarey avatar May 07 '25 08:05 demarey

Your bug got fixed (but the fix introduced an endless loop in PullUp)

It should be

defaultSelectDialog

	^ self class  defaultSelectDialog 
		  title: 'There are potential breaking changes!';
		  label: self labelBasedOnBreakingChanges;
		  items: self breakingChoices;
		  display: [ :each | each description ];
		  displayIcon: [ :each | self iconNamed: each systemIconName ];
		  openModal

and not

defaultSelectDialog

	^ self  defaultSelectDialog 
		  title: 'There are potential breaking changes!';
		  label: self labelBasedOnBreakingChanges;
		  items: self breakingChoices;
		  display: [ :each | each description ];
		  displayIcon: [ :each | self iconNamed: each systemIconName ];
		  openModal

Ducasse avatar Jun 28 '25 15:06 Ducasse

With this change your bug goes away so I will close the issue.

Ducasse avatar Jun 28 '25 15:06 Ducasse