pharo

pharo copied to clipboard

Reame
Issues

Ux fix for the strange browser toggle buttons

Open AlexisCnockaert opened this issue 1 year ago • 8 comments

Fixes #17827 Fixes #16484

-Made the buttons look all the same with checkboxes, changed the labels of the button -Now we can enable/disable everything by using checkboxes, it is more explicit than just clicking on the labels like before -Line count is not turned on by default still because we want to have people opinion on it

Mar 05 '25 09:03 AlexisCnockaert

Hum... The first option can never be checked. Just for this one I wonder if letting the little pen button that was there before is not better?

If some people want to give their opinion here is the new look:

Mar 07 '25 12:03 jecisc

Fixes #16484 too

Mar 11 '25 11:03 jecisc

@jecisc do we ask people opinion now or should we take a decision

Mar 26 '25 14:03 AlexisCnockaert

We will merge

Mar 27 '25 08:03 Ducasse

@jecisc I made the change on the checkbox

Apr 08 '25 09:04 AlexisCnockaert

We have some failures on Windows

I don't know if it's from this PR or not

Apr 08 '25 12:04 jecisc

I don't think this is related to the PR

Apr 08 '25 12:04 AlexisCnockaert

Another PR just passed. The problem seems linked to this PR. But I don't know what could cause that when I check the changes...

If I use a windows I'll try to check it

Apr 08 '25 20:04 jecisc

This has been pending for a while. Lets merge it and if I see more feedback to give we can iterate

Oct 03 '25 14:10 jecisc