pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Added new feature that allows to leave all variables undeclared if option selected in dialog

Open AlexisCnockaert opened this issue 1 year ago • 5 comments

Fixes #17460

AlexisCnockaert avatar Dec 02 '24 14:12 AlexisCnockaert

Now I think that the CodeReparator should be a presenter and that it should pass via the application to raise menu. MorphicUIManager will break.

Ducasse avatar Dec 03 '24 06:12 Ducasse

In a future step yes!

I fixed the merge conflict

jecisc avatar Dec 03 '24 13:12 jecisc

This breaks a lot of tests sadly

jecisc avatar Dec 04 '24 14:12 jecisc

The compiler architecture sucks. It should not raise UI or talk to UI elements.

Ducasse avatar Dec 12 '24 17:12 Ducasse

In a future step yes!

I fixed the merge conflict

And moreover, it does not add new tests for the new behavior.

I'm sorry but It's difficult to accept new features without tests.

Also, whenever doing UI changes, please add screenshots of the new features in the PR.

guillep avatar Dec 16 '24 11:12 guillep