pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Cleanup Shout

Open jecisc opened this issue 1 year ago • 1 comments

  • Remove #stylingEnabled: because this is never used and if we do not want to style a text, we should not give it to the styler
  • Remove #text ivar that is unused
  • Remove #plugins that are unused

Fixes #16310

jecisc avatar Oct 10 '24 14:10 jecisc

The plugins where added fairly recently, see https://github.com/pharo-project/pharo/pull/12429

MarcusDenker avatar Oct 10 '24 15:10 MarcusDenker

@jecisc cyril I think that I will integrate this. I do not see how the fact that pluging are recent changes the fact that the styler does not use them.

Ducasse avatar Feb 28 '25 08:02 Ducasse

I verified and the plugin variable was not used at all so this is clearly deadcode.

Ducasse avatar Feb 28 '25 08:02 Ducasse