pharo-project
ExtractTempDriver
I deleted the dialog related to the selector as you suggested @balsa-sarenac , before I didn't consider that there might not be a need for it, my mistake. If @Ducasse thinks otherwise, it's not a problem for me to add it again and change it so that it's an optional dialog.
@Ducasse the dialog is not working very well, so my focus is on that now. I will let you know when I fix the dialog so you can integrate it then we will see what is wrong with the tests
Hello @Ducasse, unfortunately I have been caught up with other commitments, which has slowed down my pace. Thankfully, these other obligations are getting resolved, and I hope that I will fix the dialog by Thursday. I apologize to keep you waiting.
I am sorry @Ducasse , I still haven't been able to fix the problems. There are two problems :
- no error message is printed in the dialog when the precondition is not met,
- refactoring does not make any changes.
It is possible that there are some other mistakes that I did not see. I don't do well with the presenter, not sure if the presenter is the problem or runRefactoring method. I will contact @balsa-sarenac , if he has time to take a look at the problems, maybe I should change the approach to the dialog. Again, apologies for the slow work.
Ok no problem. What is the problem? Because may be we can merge and fix the rest in another PR?
Maybe it is possible, but I am not sure how big the problems are @Ducasse. When the refactoring is started, a dialog appears, which is created using the presenter class, if the precondition is not met, an error message should be displayed in the dialog, I set the error message to a label in the presenter but I am not sure how to print it. This is the first problem, the second problem is when the correct variable is entered and the refactoring should happen there are no changes, the variable should be created and have the value of the selected interval but that is not the case, I don't know why.
Ok @balsa-sarenac do you have some cycles for this? Else we can integrate it and see later because I'm afraid that further changes will impact it.
@balsa-sarenac when I integrated this PR it broke the build
Error: Package Refactoring-UI depends on the following classes: RBInteractionDriver You must resolve these dependencies before you will be able to load these definitions: ReExtractToTemporaryDriver ReExtractToTemporaryDriver>>#changes
I will add RBInteractionDriver to be able to load it.