pharo icon indicating copy to clipboard operation
pharo copied to clipboard

ReGuardClauseRule applies incorrect rewrite to #browseReferencesTo:inNameResolver: on ClyBrowserMorph in Pharo 13 build 182

Open Rinzwind opened this issue 1 year ago • 0 comments

As encountered by @hernanmd in pull request #17004, in Pharo 13 build 182, ReGuardClauseRule applies an incorrect rewrite to #browseReferencesTo:inNameResolver: on ClyBrowserMorph. The rule should be fixed so that either the rewrite it applies is correct or that it no longer matches the method.

A side question I was wondering about in pull request #17011 is why the severity of the rule is ‘warning’ and not just ‘information’. The rule’s rationale says that the rewrite might better represent the true meaning, implying that’s not necessarily the case, so it would seem better that the rule just informs me that I could rewrite the method, not warn me that I should.

Rinzwind avatar Aug 18 '24 10:08 Rinzwind