pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Make #postload:package: on BaselineOfIDE set PharoLightTheme as current again

Open Rinzwind opened this issue 1 year ago • 2 comments

This pull request makes #postload:package: on BaselineOfIDE set PharoLightTheme as current again to be consistent with it being the default (see issue #16797).

Rinzwind avatar Aug 10 '24 09:08 Rinzwind

Thank you for this contribution. I don't think it is the right fix. The choice was done to adopt dark blue theme as default theme in Pharo 13.

I think the problem should be fixed in the settings browser. You mentionned

theme saving gets filtered out in #store on SettingsStonWriter because ‘Pharo Light’ is the default value.

Probably the default value should become dark blue in Pharo 13. And you're right that default theme should only be defined in one place.

demarey avatar Aug 14 '24 07:08 demarey

@jecisc Could you maybe extend the changes of pull request #16777 to correctly set the theme as the default then?

Rinzwind avatar Aug 14 '24 18:08 Rinzwind

https://github.com/pharo-project/pharo/pull/17087

jecisc avatar Sep 10 '24 13:09 jecisc

Thanks! Saving ‘Pharo Light’ for ‘User interface theme’ to disk works now.

Rinzwind avatar Sep 13 '24 18:09 Rinzwind