Fix + Tests for Pharo12 bug for issue #16702

[bouraqadi]

Trait class side methods sometimes not installed on user classes

[tesonep]

Thanks so much @bouraqadi Do you know if this change should be done also in P13? Thanks again

[bouraqadi]

Hi Pableo,

The answer is yes. The fix should be applied to P13 too. I just tried on P13. Tests alone fail. With the fix, they turn green.

Thanks, Noury On Jun 3 2024, at 9:49 am, Pablo Tesone @.***> wrote:

Thanks so much @bouraqadi (https://github.com/bouraqadi) Do you know if this change should be done also in P13? Thanks again

— Reply to this email directly, view it on GitHub (https://github.com/pharo-project/pharo/pull/16736#issuecomment-2144506600), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AADKJD7MB4QQ4XLQMNL4TCTZFQNZZAVCNFSM6AAAAABISWWDIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBUGUYDMNRQGA). You are receiving this because you were mentioned.

[tesonep]

Great, thanks.

[tesonep]

The failing test are related

[bouraqadi]

Yes. The one I provide with the fix. And they pass once the fix is installed. On Jun 3 2024, at 4:05 pm, Pablo Tesone @.***> wrote:

The failing test are related — Reply to this email directly, view it on GitHub (https://github.com/pharo-project/pharo/pull/16736#issuecomment-2145292641), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AADKJD3G3T56YHM6ULKSAALZFRZ23AVCNFSM6AAAAABISWWDIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVGI4TENRUGE). You are receiving this because you were mentioned.

[bouraqadi]

BTW, I did a PR backporting the fix and the tests to Pharo 11. https://github.com/pharo-project/pharo/pull/16737 On Jun 3 2024, at 4:10 pm, Noury Bouraqadi @.***> wrote:

Yes. The one I provide with the fix. And they pass once the fix is installed. On Jun 3 2024, at 4:05 pm, Pablo Tesone @.***> wrote:

The failing test are related — Reply to this email directly, view it on GitHub (https://github.com/pharo-project/pharo/pull/16736#issuecomment-2145292641), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AADKJD3G3T56YHM6ULKSAALZFRZ23AVCNFSM6AAAAABISWWDIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVGI4TENRUGE). You are receiving this because you were mentioned.

[MarcusDenker]

I do not understand why the test are failing. This PR contains both the tests and the fix, or not?

 Fuel.Core.Tests.FLCreateClassSerializationTest.testCreateWithTraitOnClassSide	10 sec	1
 Fuel.Core.Tests.FLCreateTraitSerializationTest.testCreateWithTraitOnClassSide	10 sec	1
 ReleaseTests.ProperlyImplementedSUnitClassesTest.testAndMakeSureSuperTearDownIsCalledAsLastMessageInTearDownMethodsOfTestCases	0.44 sec	1
 Slot.Tests.SlotTraitsTest.testClassWithClassTrait	1.8 sec	1
 Slot.Tests.SlotTraitsTest.testModifyClassTraitComposition	1.7 sec	1
 Slot.Tests.SlotTraitsTest.testRemoveClassTrait	1.6 sec	1
 Slot.Tests.SlotTraitsTest.testTraitUsersAfterClassReshape	1.5 sec	1
 Slot.Tests.SlotTraitsTest.testTraitUsersAfterMetaclassReshape	1.5 sec	1
 Traits.Tests.TraitFileOutTest.testFileOutCategory	10 sec	1
 Traits.Tests.TraitFileOutTest.testFileOutTrait	9.7 sec	1
 Traits.Tests.TraitFileOutTest.testRecompiling	10 sec	1
 Traits.Tests.TraitFileOutTest.testRemovingMethods

[bouraqadi]

Strange. It should pass for P12. BTW, I did another PR fro P13 https://github.com/pharo-project/pharo/pull/16758

[MarcusDenker]

This PR is for Pharo12 and the test fail. Traits tests.

[bouraqadi]

Fixed in PR #16823