pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Some Linux distros are distributing a new version of the libgit2 library not listed in LGitLibrary>>#unix64LibraryName

Open gcotelli opened this issue 3 months ago • 4 comments

Bug description Manjaro Linux is distributing libgit2 v1.8 making Iceberg fail with an error of library not found.

This is the relevant release of the library

There are some breaking changes maybe affecting the libgit2 bindings:

Breaking changes

  • Changes to git_config_entry (ABI breaking change) The git_config_entry structure now contains information about the backend_type >and origin_path. The unused payload value has been removed.

  • git_push_options includes remote push options (ABI breaking change) The git_push_options structure now contains a value for remote push options.

To Reproduce Steps to reproduce the behavior:

  1. Open Iceberg in a Pharo 12 image where the underlying Linux OS has only libgit2 1.8 installed.
  2. You must see something like this: image

Expected behavior Updated support for libgit2 1.8

Version information:

  • OS: Manjaro Linux
  • Pharo Version
    • Pharo-12.0.0+SNAPSHOT.build.1510.sha.7efef560919a459de9e2fad384ee4614fdcb1691 (64 Bit)
    • PharoVM 10.2.0-f4c5e2aa5 built on May 9 2024 09:04:25

Expected development cost Adding the library name to LGitLibrary>>#unix64LibraryName is trivial. Someone with more knowledge of libgit2 binding internals needs to evaluate if the breaking changes affect the behavior used by Pharo or not, and requires changes in the external object structs

gcotelli avatar May 20 '24 12:05 gcotelli