pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Published 20 hours ago • verified publisher icon pharo-project

Rename RBNode into ASTNode

Open jecisc opened this issue 9 months ago • 3 comments

Rename RBNode into ASTNode.

I could try to do all AST classes at once but I tried multiple time in the past and it failed and the PR was huge so I'm doing the first easy step here.

jecisc avatar May 07 '24 21:05 jecisc

Hi @jecisc could this be made backwards compatible? Why not a deprecation? This will break a lot of clients that are outside of the image otherwise.

guillep avatar May 07 '24 21:05 guillep

I added a deprecated alias in the poast load of BaselineOfIDE.

I cannot use the initialize method since this code is not loaded by Monticello

jecisc avatar May 07 '24 21:05 jecisc

Failures seems unrelated now

jecisc avatar May 08 '24 23:05 jecisc

Cyril this is important that we do not remove this names in P14. And is the alias also rewriting the code?

Ducasse avatar Jun 13 '24 18:06 Ducasse

It rewrites extension methods holders but not references. Marcus would like to add that in Pharo 13

jecisc avatar Jun 14 '24 14:06 jecisc