pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Reflectivity fixing bytecode to ast mapping

Open StevenCostiou opened this issue 10 months ago • 3 comments

Fixing a bug in syntax highlighting in the debugger because there is a desync between methods on the stack and methods modified with breakpoints in the system.

With @MarcusDenker

Step 1

[x] Moving the metalink count from the reflective method to the method node (as a property) [ ] Ensure that every compiled method has its own reflective method

Step 2

[ ] Move the bytecode-ast mapping to the method node [ ] Move the dedicated bytecode-mappings of blocks to a dictionary in their parent method node bytecode-mappings

StevenCostiou avatar Apr 19 '24 13:04 StevenCostiou

This PR has one failing test: osx-64 / Tests-osx-64 / testLinkCountTwoLinks – MacOSX64.Reflectivity.Tests.ReflectiveMethodTest

jecisc avatar Apr 20 '24 20:04 jecisc

The tests are still buiding using Pharo12 somehow

MarcusDenker avatar May 07 '24 13:05 MarcusDenker

I'm running the tests again, as I plan to work on it today.

StevenCostiou avatar May 16 '24 07:05 StevenCostiou

Test pass now. Can someone merge? I will do the other changes in another PR later.

StevenCostiou avatar May 27 '24 14:05 StevenCostiou