pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Loading baseline with EpMonitor doesn't tell it succeded

Open doste opened this issue 1 year ago • 2 comments

When loading a baseline through a Playground, Metacello doesn't show that it succeded in the installation. In the tab bar of the Playground it shows 'running' just as while the installation was happening.

Steps to reproduce the behavior:

  1. Open a Playground.
  2. Try to install a baseline, like:
EpMonitor disableDuring: [
  Author useAuthor: 'Load' during: [
    [	Metacello new
        baseline: 'BlocBenchs';
        repository: 'github://pharo-graphics/BlocBenchs:master/src';
        onConflictUseIncoming;
        ignoreImage;
        load.
    ]	on: MCMergeOrLoadWarning
      do: [ :warning | warning load ] ] ]
  1. It doesn't tell you it finished, so you have to check manually if the baseline is installed.

Expected behavior: Some kind of feedback that the baseline was successfully loaded.

Version information:

  • OS: macOS Sonoma 14.3.1
  • Pharo Version: 12

doste avatar Mar 12 '24 15:03 doste

Thanks for opening your first issue! Please check the CONTRIBUTING documents for some tips about which information should be provided. You can find information of how to do a Pull Request here: https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo

GitHub
Pharo is a dynamic reflective pure object-oriented language supporting live programming inspired by Smalltalk. - pharo-project/pharo

welcome[bot] avatar Mar 12 '24 15:03 welcome[bot]

I'm not an expert in Metacello, but from what I've seen, in P13, Metacello loads statements, each one of which is a "script" loaded in a session using dynamic variables (IceMetacelloLoadSessionContext).

To notify successful loading, one could add MCLoadSuccess or MCSuccessLoad.

But there are multiple points where this could be implemented: MetacelloScriptApiExecutor, MetacelloScriptEngine, etc., and someone more knowledgeable could drop some lines here. Maybe @guillep ?

hernanmd avatar Jun 06 '24 13:06 hernanmd