pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Refactor MenuItemMorph to support use of a FormSet and apply that to CmdCommand

Open Rinzwind opened this issue 1 year ago • 1 comments

This pull request refactors MenuItemMorph to support use of a FormSet for the icon and applies that to the CmdCommand hierarchy. In the CmdCommand hierarchy, the overrides of #defaultMenuIcon are refactored to override #defaultMenuIconName instead.

Rinzwind avatar Feb 18 '24 16:02 Rinzwind

I converted this to a draft. Commit 02f48dcb43a0cc8d introduces a bug in #setUpIconForMenuItem: where the argument, despite the variable name ‘aMenuItemMorph’, can also be a PragmaMenuAndShortcutRegistration, which does not understand #iconFormSet:.

Rinzwind avatar Feb 18 '24 16:02 Rinzwind

I fixed the bug referred to in my previous message by first refactoring PluggableMenuItemSpec and PragmaMenuAndShortcutRegistrationItem as well.

Rinzwind avatar Feb 18 '24 19:02 Rinzwind

@jecisc can you check it? Tx

Ducasse avatar Feb 24 '24 17:02 Ducasse

@jecisc Could I ask for an update on the (re)review? If you’re not available, it might be better to let someone else take over?

Rinzwind avatar Mar 04 '24 17:03 Rinzwind