pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Context menu item ‘Revert to selected version’ in recent versions of a method does not revert

Open Rinzwind opened this issue 1 year ago • 2 comments

In Pharo 12 build 1323, the context menu item ‘Revert to selected version’ in the recent versions of a method does not seem to work. The balloon text also seems wrong:

The ‘Revert’ toolbar button does work.

Rinzwind avatar Jan 28 '24 10:01 Rinzwind

Also: all of the other toolbar buttons (‘Browse’, ‘References’, ‘Senders’ and ‘Implementors’) cause a MessageNotUnderstood to be signaled.

Rinzwind avatar Jan 28 '24 11:01 Rinzwind

This is the price to pay when we do not write tests. :(

Ducasse avatar Jan 28 '24 12:01 Ducasse

Experienced the same bug here. I think this should be fixed before releasing P12.

bouraqadi avatar Feb 23 '24 13:02 bouraqadi

No suprize revert does not work. Method StVersionBrowserPresenter >> #doRevert is empty!

bouraqadi avatar Feb 23 '24 13:02 bouraqadi

This issue actually belongs to NewTools.
Bug fixed + PR opened.

bouraqadi avatar Feb 23 '24 14:02 bouraqadi

fix merged

MarcusDenker avatar Feb 26 '24 07:02 MarcusDenker

Thanks! I quickly tried it out using Pharo 12 build 1402. The menu item ‘Revert to selected version’ works again. But the balloon text still seems wrong. The toolbar buttons ‘Browse’, ‘References’, ‘Senders’ and ‘Implementors’ also still cause a MessageNotUnderstood to be signaled.

Perhaps this should be reopened, or should a new issue be opened?

Rinzwind avatar Feb 26 '24 13:02 Rinzwind