pharo icon indicating copy to clipboard operation
pharo copied to clipboard

support for .st/.cs files file-in was accidentally removed toghether with ChangeSet class

Open pavel-krivanek opened this issue 7 months ago • 6 comments

Bug description The Pharo 12 lost support for old-style source files (.st, .cs) and should probably be returned because the code support in the image still remains. See ChangeSet class>>#fileReaderServicesForFile:suffix: and other methods in the categorry that were removed.

pavel-krivanek avatar Jan 08 '24 09:01 pavel-krivanek

Hi Pavel, In Pharo 12 if you open the File Browser, select a .st file to file in, right-click and click on "Changelist browser" item, a new Changes Browser window will open. From there you can select the changes you want to file in.

Does that work for you?

hernanmd avatar Jan 08 '24 11:01 hernanmd

before, if you dropped a file into Pharo window, you had an option to directly file-in the content of the file ("Install into the image" option). The same for the context menu in the File browser.

pavel-krivanek avatar Jan 08 '24 12:01 pavel-krivanek

It seems weird to me that to code dealing with importing .st files was in the change set.

I think we should add back the feature but in the code importer (or in the code adding the services if it is loaded later) without a dependency to the change sets.

jecisc avatar Jan 08 '24 13:01 jecisc

Well, this should be managed by a more UI part right? Either the Application or window (if spec). Or the "World"?

guillep avatar Jan 08 '24 13:01 guillep

At least the registry.

guillep avatar Jan 08 '24 13:01 guillep

This is managed by the <fileService> pragma. So maybe it should be with FileService?

jecisc avatar Jan 08 '24 13:01 jecisc