pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Package does not understand buildMicroDownUsing: builder withComment: aString

Open Ducasse opened this issue 1 year ago • 5 comments

So we lost this method from P11.

Ducasse avatar Jan 04 '24 19:01 Ducasse

I do not really get this

ClyPackageRichTextCommentEditorToolMorph >> renderComment: aString of: aClassOrPackage 
	"The actual implementation is moved to BeautifulComments - basically to allow Testing"
	
	^ BeautifulComments renderComment: aString of: aClassOrPackage

Ducasse avatar Jan 04 '24 19:01 Ducasse

Capture 2024-01-04 at 20 11 08

Ducasse avatar Jan 04 '24 19:01 Ducasse

I fixed it here https://github.com/pillar-markup/Microdown/pull/675 But tests are failing and then 99.9% of changes are formatting.

Should I open another issue in Microdown to fix the failing tests?

hernanmd avatar Jan 18 '24 16:01 hernanmd

Thanks hernan. I'm flooded by work. So I do not know. I will check for the tests before integrating this change.

Ducasse avatar Jan 18 '24 16:01 Ducasse

No problem Stef. I just opened an issue here: https://github.com/pillar-markup/Microdown/issues/681 So it would be necessary to fix Microdown issues.

hernanmd avatar Jan 29 '24 16:01 hernanmd

Ok I released a version of microdown for P12 and it should fix this problem. It is V2.5.0. Now we should merge it into pharo12. But I want to do it with people around and not when many are on vacation.

Ducasse avatar Feb 24 '24 19:02 Ducasse

I merge V2.5.0 of microdown in the microdown branch Pharo12 so this bug should be fixed.

Ducasse avatar Mar 12 '24 12:03 Ducasse

I confirm this is done

estebanlm avatar Mar 14 '24 09:03 estebanlm

nice to know.

Ducasse avatar Mar 14 '24 15:03 Ducasse