pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Execute Release-Tests last on CI

Open jecisc opened this issue 1 year ago • 5 comments

We have a lot of tests in Pharo and it might happen that some of them do not respect the principle of letting the system clean with their tearDown. To help to spot those impacts, I propose to run the releases tests last. Like this, if some bad generated code/or modifications of system entities happens, we might catch it with the verifications of release tests.

I expect this commit to break the tests in the CI but it'll help me find the culprits and fix them.

jecisc avatar Apr 07 '23 14:04 jecisc

Nice.

Since tests force the coverage (of) some code, thus performs code transformation because of deprecation, is there a release test that check that the code is pristine/unmodified?

privat avatar Apr 07 '23 15:04 privat

There is none yet, but I would love to have that :)

jecisc avatar Apr 07 '23 15:04 jecisc

But we will need some work to get it because in Pharo 12 it comes with dirty packages, so this test would fail currently

jecisc avatar Apr 07 '23 15:04 jecisc

More than 10 tests failures because the tests are dirtying the image D:

jecisc avatar Apr 07 '23 18:04 jecisc

Here is a first fix: https://github.com/pharo-spec/NewTools/pull/504

jecisc avatar Apr 08 '23 16:04 jecisc