pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Published 20 hours ago • verified publisher icon pharo-project

11613-Review-RBLiteralNode-classvalue

Open MarcusDenker opened this issue 2 years ago • 1 comments

add a comment explaining why we do not use #isByteArray here, fixes #11613

(I do not like the method, maybe the check should be done by the user...

MarcusDenker avatar Sep 21 '22 11:09 MarcusDenker

Failing tests not related:

  • [CI] Failing test: ProperMethodCategorizationTest>>testNoUncategorizedMethods #11669
  • [CI] two failing test in SpCommandTest #11702

MarcusDenker avatar Sep 21 '22 12:09 MarcusDenker

It took me while to understand. May be the comment should say value argument can be x or y.

Ducasse avatar Sep 22 '22 05:09 Ducasse